build: run perfetto build and test on GHA - #64721
Conversation
|
Review requested:
|
nodejs-github-bot
added
the
meta
legendecas
added
dont-land-on-v22.x
| path: node | ||
| - name: Install Clang ${{ env.CLANG_VERSION }} | ||
| uses: ./node/.github/actions/install-clang | ||
| with: | ||
| clang-version: ${{ env.CLANG_VERSION }} |
There was a problem hiding this comment.
| path: node | |
| - name: Install Clang ${{ env.CLANG_VERSION }} | |
| uses: ./node/.github/actions/install-clang | |
| with: | |
| clang-version: ${{ env.CLANG_VERSION }} | |
| - name: Install Clang ${{ env.CLANG_VERSION }} | |
| uses: .github/actions/install-clang | |
| with: | |
| clang-version: ${{ env.CLANG_VERSION }} |
nit: use the CWD
There was a problem hiding this comment.
I replicated this from https://github.com/nodejs/node/blob/main/.github/workflows/test-linux-quic.yml. Maybe it was replicated from https://github.com/nodejs/node/blob/main/.github/workflows/test-linux.yml
avivkeller
left a comment
avivkeller
left a comment
There was a problem hiding this comment.
LGTM, we should probably update the other workflows to use the CWD, IMO it's cleaner
|
Could we enable this for the existing Linux workflow rather than adding an additional run? |
We could. Still, I think in the near future, we might want to keep testing both legacy tracing and perfetto tracing, until we can fully deprecate the legacy one. |
There was a problem hiding this comment.
For other flags (except QUIC, but the QUIC job being restricted to a very limited set of files, that's less of a concern), we put this as part of the test-shared workflow. Can we do that here as well? Having a dedicated job is probably a waste and won't scale well.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64721 +/- ##
==========================================
- Coverage 90.15% 90.13% -0.02%
==========================================
Files 746 746
Lines 242648 242648
Branches 45720 45717 -3
==========================================
- Hits 218758 218714 -44
- Misses 15397 15438 +41
- Partials 8493 8496 +3 🚀 New features to boost your workflow:
|
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
6 participants
This ensures that the
src/libchanges (like emitting trace events) are compatible with perfetto, and compatible with V8 compiled with perfetto.Refs: #64565
Fixes: nodejs/diagnostics#654